Allow expectations on subclass any instance methods. #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonRowe will you try to fix the build? I'm now also getting this issue with the |
|
@nunommc I'm not sure I have the time, if you'd like to takeover feel free |
JonRowe
force-pushed
the
allow_any_instance_sub_class_mocks
branch
from
9562a60
to
a255002
Compare
JonRowe
force-pushed
the
allow_any_instance_sub_class_mocks
branch
from
a255002
to
ab56cf5
Compare
JonRowe
force-pushed
the
allow_any_instance_sub_class_mocks
branch
from
ab56cf5
to
4dba1ec
Compare
|
We faced #1077 today, would be great to have this fix finally merged. |
|
@arg it's not finished and I'm not currently working on it, feel free to pick it up from here if you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to override methods which are present on a parent and subclass with
any_instance_of.Closes #1077, /cc @samphippen