Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure backtraces start at user code, not rspec-mocks code #1593

Closed
wants to merge 1 commit into from

Conversation

onlynone
Copy link

This will ensure all exceptions generated by rspec-mocks have the first line of their backtraces pointing to the user's code where the error happened.

Addresses #1592

@pirj
Copy link
Member

pirj commented Sep 17, 2024

HunkGenerator on 2.2 and 2.5 is flaky.

@pirj
Copy link
Member

pirj commented Sep 17, 2024

Do you need some help with JRuby support?

@JonRowe JonRowe closed this Sep 17, 2024
@JonRowe
Copy link
Member

JonRowe commented Sep 17, 2024

We already handle this in rspec-core and as per #1592 I don't want to add the maintenance burden of this, it would duplicate logic we have elsewhere. Additionally to our filtering we also have the ability to remove the filtering to allow finding issues within our, or any other filtered out code which this would circumvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants