Trim line length in error generator #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm noticing that the |
|
Thought about it, didn't do it the first time. Pushing a commit that does it now. |
fables-tales
force-pushed
the
samphippen/trim-error-generator-lines
branch
from
38223df
to
09e8fff
Compare
| __raise(default_error_message(intro, expectation, expected_args, actual_args)) | ||
| end | ||
|
|
||
| def default_error_message(intro, expectation, expected_args, actual_args) |
There was a problem hiding this comment.
intro is a helper method. It doesn't need to be passed as an argument.
fables-tales
force-pushed
the
samphippen/trim-error-generator-lines
branch
from
09e8fff
to
cbc739a
Compare
|
I'd like to merge this today. @myronmarston @JonRowe @xaviershay @cupakromer @yujinakayama @soulcutter can one of you take a look at this and let me know if it's good? |
|
LGTM |
fables-tales
pushed a commit
that referenced
this pull request
Oct 23, 2014
Trim line length in error generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #751 @JonRowe suggested trimming the line length in error_generator.rb. This patch does that via use of a string join over the parts of the string that were getting built. I prefer this solution to breaking a long string over many lines or shovelling because parts can easily be added/removed from the lists that are joined together.
Thoughts?