Fix failing fixture support test on Rails main #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is failing since setup_fixtures was made private in rails/rails@29fe344. It was added in 82241e9 to exercise the call to `name` in Rails' `run_in_transaction?` method: https://github.com/rails/rails/blob/b4ab1f19d8bcc4639c7379b560f000f01753b5b0/activerecord/lib/active_record/test_fixtures.rb#L101 However since 9272757, RSpec Rails overrides `run_in_transaction?`, so `name` is no longer called. We can get even better integration coverage of an example group with use_transactional_tests set to false by actually running an example.
|
Thanks! |
JonRowe
added a commit
that referenced
this pull request
Feb 23, 2024
Fix failing fixture support test on Rails main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is failing since
setup_fixtureswas made private in rails/rails#51021.It was added in #2215 to exercise the call to
namein Rails'run_in_transaction?method: https://github.com/rails/rails/blob/b4ab1f19d8bcc4639c7379b560f000f01753b5b0/activerecord/lib/active_record/test_fixtures.rb#L101However since #2461, RSpec Rails overrides
run_in_transaction?, sonameis no longer called. We can get even better integration coverage of an example group withuse_transactional_testsset to false by actually running an example.