Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate issue with large nokogiri documents #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Apr 16, 2015

Large nokogiri documents expand to even larger when pp'd, and this produces very complex diffs that take a long time to produce, I'm not sure if we have a solution for this but it's the source of rspec/rspec-expectations#773

@benoittgt
Copy link
Member

@JonRowe I don't see any activities on this issue since 4 years. I am in favor of closing it. What do you think?

@JonRowe
Copy link
Member Author

JonRowe commented Jun 12, 2019

@benoittgt this is a bit confusing because of the rebase, but its worth leaving open as its an issue rather than a stale PR

@JonRowe JonRowe force-pushed the demonstate_diff_issue_with_nokogiri branch from f74f31b to 47b9695 Compare June 12, 2019 20:32
@JonRowe JonRowe force-pushed the demonstate_diff_issue_with_nokogiri branch from 47b9695 to f1d486b Compare May 2, 2020 20:54
@JonRowe JonRowe changed the base branch from master to main August 2, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants