updating default R version in PPM #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fh-mthomson
reviewed
May 31, 2023
| @@ -116,7 +116,7 @@ The Helm `config` values are converted into the `rstudio-pm.gcfg` service config | |||
| | awsAccessKeyId | bool | `false` | awsAccessKeyId is the access key id for s3 access, used also to gate file creation | | |||
| | awsSecretAccessKey | string | `nil` | awsSecretAccessKey is the secret access key, needs to be filled if access_key_id is | | |||
| | command | bool | `false` | command is the pod's run command. By default, it uses the container's default | | |||
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/3.6.2/"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |||
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/4.2.0/bin/R"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |||
There was a problem hiding this comment.
We also ran across this issue and set manually as done here; thanks for adding to the upstream chart!
Note: per the docs here, the bin/R is not recommended
Suggested change
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/4.2.0/bin/R"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/4.2.0/"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | |
There was a problem hiding this comment.
Use the default version (symlink) inside the container.
Suggested change
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/4.2.0/bin/R"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/default/"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | |
bschwedler
reviewed
Jul 28, 2023
| @@ -116,7 +116,7 @@ The Helm `config` values are converted into the `rstudio-pm.gcfg` service config | |||
| | awsAccessKeyId | bool | `false` | awsAccessKeyId is the access key id for s3 access, used also to gate file creation | | |||
| | awsSecretAccessKey | string | `nil` | awsSecretAccessKey is the secret access key, needs to be filled if access_key_id is | | |||
| | command | bool | `false` | command is the pod's run command. By default, it uses the container's default | | |||
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/3.6.2/"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |||
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/4.2.0/bin/R"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |||
There was a problem hiding this comment.
Use the default version (symlink) inside the container.
Suggested change
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/4.2.0/bin/R"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | | |
| | config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"RVersion":"/opt/R/default/"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file | |
| @@ -228,7 +228,7 @@ serviceMonitor: | |||
| # -- config is a nested map of maps that generates the rstudio-pm.gcfg file | |||
| config: | |||
| Server: | |||
| RVersion: "/opt/R/3.6.2/" | |||
| RVersion: "/opt/R/4.2.0/bin/R" | |||
There was a problem hiding this comment.
Use the default version (symlink) inside the container.
Suggested change
| RVersion: "/opt/R/4.2.0/bin/R" | |
| RVersion: "/opt/R/default/" |
| @@ -1,6 +1,6 @@ | |||
| name: rstudio-pm | |||
| description: Official Helm chart for RStudio Package Manager | |||
| version: 0.5.7 | |||
| version: 0.5.8 | |||
There was a problem hiding this comment.
Do you think we should update this to 0.6.0 since it could be a breaking change for some?
There would be two changes
- R v3 is no longer installed by default
- Rely on the default R version inside the container instead of pinning to a specific R version.
|
Symlinks were added to the containers for the default versions of R & Python, which correspond to the image tags: rstudio/rstudio-docker-products#601 We probably want to do this in conjunction with the next Package Manager release, since we are currently pinned on |
This was referenced Jul 28, 2023
|
This has been superseded by #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.