Move ci directory outside of the chart directory structure, and break it into two. One set of values for linting, one for installation testing #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues for install testing. Update the workflow to create the symlinks as needed as well as clean up the symlinks after
…helm into add-ci-lint-and-ci-install-dirs
jspiewak
reviewed
Oct 15, 2024
jspiewak
reviewed
Oct 15, 2024
…helm into add-ci-lint-and-ci-install-dirs
…rvice: no storers found for v1/metrics'
jforest
requested review from
aronatkins,
dbkegley,
christierney,
zackverham and
a team
as code owners
jforest
changed the title
jspiewak
reviewed
Oct 16, 2024
jspiewak
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separation of values files into
ci-lintandci-installis required for now, because the current values files in thecidirectory do not pass install tests. We need to create a full set of values files that both pass linting AND install tests. Once that is complete we can move those universal files back intociand remove this silly process. #585Update the workflow to create the symlinks as needed
I had to create some
basic-values.yamlfiles for the install testing of the charts. The values added were the ones I needed in order for the charts to pass the install tests. Empty values didn't work for those ones: #587closes #586
EDIT Also moving the values files out of the chart directories themselves. That way we can modify test values without having to increment the chart versions