Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cssSelector to methods like tagAppendChildren(..., .cssSelector = NULL) #251

Closed
schloerke opened this issue May 11, 2021 · 3 comments · Fixed by #224
Closed

Add .cssSelector to methods like tagAppendChildren(..., .cssSelector = NULL) #251

schloerke opened this issue May 11, 2021 · 3 comments · Fixed by #224

Comments

@schloerke
Copy link
Collaborator

If the .cssSelector is not NULL, call tagQuery(tag)$find(.cssSelector)$append(...)$allTags().

Do this for other method like tagAppendChildren().

This gives more motivation to export tagInsertChildren() (#225)

@wch
Copy link
Collaborator

wch commented May 11, 2021

We'll need to make sure that users are aware that if they do this, it goes through tagQuery(), and is subject to whatever changes tagQuery will make to the object. For example, lists and tagLists will be flattened when this happens. I don't know offhand what other changes tagQuery() will make, but we should make sure they're all documented.

@schloerke
Copy link
Collaborator Author

Should just be the flattening of TAG$children into a single list

@schloerke
Copy link
Collaborator Author

Internal tag name ordering is fixed in #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants