Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagQuery() docs; Add .cssSelector parameter to tag methods #224

Merged
merged 41 commits into from
May 13, 2021

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Apr 20, 2021

Closes #218
Closes #234
Closes #251

R/tag_query.R Outdated Show resolved Hide resolved
R/tag_query.R Outdated Show resolved Hide resolved
R/tag_query.R Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@wch
Copy link
Collaborator

wch commented May 3, 2021

We should make sure the vignette is only a part of the website, and not included in the built package, because it can bloat the package size.

NEWS.md Outdated Show resolved Hide resolved
R/tag_query.R Outdated Show resolved Hide resolved
R/tag_query.R Outdated Show resolved Hide resolved
R/tag_query.R Show resolved Hide resolved
@cpsievert cpsievert marked this pull request as ready for review May 4, 2021 17:08
@cpsievert cpsievert requested a review from schloerke May 4, 2021 17:08
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your work LGTM!

Diff outputs in the performance section would be much easier given #249

@schloerke schloerke changed the title tagQuery() docs tagQuery() docs; Add .cssSelector parameter to tag methods May 13, 2021
@schloerke schloerke merged commit 684675c into master May 13, 2021
@schloerke schloerke deleted the tagQueryDocs branch May 13, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants