-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tagQuery()
docs; Add .cssSelector
parameter to tag methods
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Apr 20, 2021
cpsievert
commented
Apr 20, 2021
cpsievert
commented
Apr 21, 2021
This was referenced Apr 22, 2021
wch
reviewed
Apr 27, 2021
We should make sure the vignette is only a part of the website, and not included in the built package, because it can bloat the package size. |
wch
approved these changes
May 3, 2021
cpsievert
commented
May 3, 2021
cpsievert
commented
May 3, 2021
cpsievert
commented
May 3, 2021
cpsievert
commented
May 3, 2021
* master: Do not force suggested pkgs on devel in GHA (#244)
schloerke
reviewed
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your work LGTM!
Diff outputs in the performance section would be much easier given #249
* master: `tagQuery()`: Speed enhancements and consistent tag name order (#249)
schloerke
changed the title
tagQuery() docs
May 13, 2021
tagQuery()
docs; Add .cssSelector
parameter to tag methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218
Closes #234
Closes #251