Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hyphens in tag/element css selectors #355

Closed
slodge opened this issue Nov 10, 2022 · 1 comment · Fixed by #354
Closed

Support hyphens in tag/element css selectors #355

slodge opened this issue Nov 10, 2022 · 1 comment · Fixed by #354

Comments

@slodge
Copy link
Contributor

slodge commented Nov 10, 2022

We're using some libraries at the moment which have hyphened tag names.

This is an increasingly common scenario because of web components and the Custom Elements spec

The current selector implementation doesn't seem to support hyphens (or some other characters like underscores) - so I'm looking at extending this - see start of work in #354

@slodge slodge changed the title Element Css Selectors need to support hyphens Element css selectors need to support hyphens Nov 10, 2022
@slodge slodge changed the title Element css selectors need to support hyphens Support hyphens in tag/element css selectors Nov 10, 2022
@slodge
Copy link
Contributor Author

slodge commented Nov 15, 2022

PR is now ready for review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant