-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS selection rules should include hyphens and underscores #354
Conversation
Allow selections of examples like: - `<my-hyphened-tag />` - `<my_underscored_tag />` - `<div class="my-hyphened-class" />` - `<div class="my_underscored_class" />` - `<div id="my-hyphened-id" />` - `<div id="my_underscored_id" />` Todo: [x] Change the selector.R code [ ] Update tests
Stuart Lodge seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏👏 Some cosmetic changes to make then we'll merge the PR. Thank you!
Co-authored-by: Barret Schloerke <[email protected]>
Co-authored-by: Barret Schloerke <[email protected]>
Co-authored-by: Barret Schloerke <[email protected]>
Saw this error... have pushed some changes - but they're nothing to do with this commit... Personally I'm very happy with GitHub Actions running document instead of developers - sounds like a perfect place for automation to reduce work rather than adding to it :) (insert post-xmas back-at-work fat and grumpy Stuart emoji here) |
GHA |
Fixes #355
Extend the current regexes to allow selections of examples like:
<my-hyphened-tag />
<my_underscored_tag />
<div class="my-hyphened-class" />
<div class="my_underscored_class" />
<div id="my-hyphened-id" />
<div id="my_underscored_id" />
<my-hyphened-tag id="my_underscored_id" class="my_underscored_class my-hyphened-class" />
These are valid identifiers based on https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier
Todo: