Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagQuery(): Speed enhancements and consistent tag name order #249

Merged
merged 17 commits into from
May 13, 2021
Merged

tagQuery(): Speed enhancements and consistent tag name order #249

merged 17 commits into from
May 13, 2021

Commits on May 10, 2021

  1. Remove outdated call / approach

    @schloerke
    schloerke committed May 10, 2021
    Configuration menu
    Copy the full SHA
    4ea73b1 View commit details
    Browse the repository at this point in the history

  2. Reorder names to match standard tag order

    @schloerke
    schloerke committed May 10, 2021
    Configuration menu
    Copy the full SHA
    0968bb1 View commit details
    Browse the repository at this point in the history

  3. No need for custom testing. Use standard expect_equal(x,y)

    @schloerke
    schloerke committed May 10, 2021
    Configuration menu
    Copy the full SHA
    a0644d4 View commit details
    Browse the repository at this point in the history

  4. Update tag_query.R

    @schloerke
    schloerke committed May 10, 2021
    Configuration menu
    Copy the full SHA
    ad81536 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Use custom tag comparison to make sure no extra

    @schloerke
    schloerke committed May 12, 2021
    Configuration menu
    Copy the full SHA
    0af4160 View commit details
    Browse the repository at this point in the history

  2. Correct some bad expectation function changes

    @schloerke
    schloerke committed May 12, 2021
    Configuration menu
    Copy the full SHA
    bcb5d8b View commit details
    Browse the repository at this point in the history

  3. Add test to check for name order is preserved after test.

    @schloerke
    schloerke committed May 12, 2021
    Configuration menu
    Copy the full SHA
    776e85f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Carson Sievert <[email protected]>
    @schloerke @cpsievert
    schloerke and cpsievert authored May 12, 2021
    Configuration menu
    Copy the full SHA
    83a8e4c View commit details
    Browse the repository at this point in the history

  5. Move init of xNames down

    @schloerke
    schloerke committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a28ef99 View commit details
    Browse the repository at this point in the history

  6. Only reorder if the names are different

    @schloerke
    schloerke committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a4056ee View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. When copying attributes, use switch over setdiff

    @schloerke
    schloerke committed May 13, 2021
    Configuration menu
    Copy the full SHA
    4f73f80 View commit details
    Browse the repository at this point in the history

  2. Use helper method to remove class names to avoid call to unique

    @schloerke
    schloerke committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d545184 View commit details
    Browse the repository at this point in the history

  3. Use mget() and for loops for speed gains. (Reduce small test speed … 

    …by 1/3)
    @schloerke
    schloerke committed May 13, 2021
    Configuration menu
    Copy the full SHA
    e184bbb View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Winston Chang <[email protected]>
    @schloerke @wch
    schloerke and wch authored May 13, 2021
    Configuration menu
    Copy the full SHA
    3e9cf2b View commit details
    Browse the repository at this point in the history

  5. Add back comment about special attribute names

    @schloerke
    schloerke committed May 13, 2021
    Configuration menu
    Copy the full SHA
    a191758 View commit details
    Browse the repository at this point in the history

  6. Perform name, attribs, and children safety checks when calling … 

    …`asTagEnv()`
    @schloerke
    schloerke committed May 13, 2021
    Configuration menu
    Copy the full SHA
    f70b2b5 View commit details
    Browse the repository at this point in the history

  7. Test both removal and setting to NULL of name, attribs, and `chil… 

    …dren`
    @schloerke
    schloerke committed May 13, 2021
    Configuration menu
    Copy the full SHA
    294dbce View commit details
    Browse the repository at this point in the history