Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -DNDEBUG to libuv build #369

Merged
merged 3 commits into from
May 10, 2023
Merged

Add -DNDEBUG to libuv build #369

merged 3 commits into from
May 10, 2023

Conversation

nealrichardson
Copy link
Contributor

I can confirm this is working because I now see in the libuv build:

src/unix/darwin.c:214:17: warning: variable 'kr' set but not used [-Wunused-but-set-variable]
  kern_return_t kr;
                ^

AFAICT kr is only used in assert() statements that NDEBUG removes. This appears not to have an affect on the R CMD check results.

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@nealrichardson nealrichardson mentioned this pull request May 10, 2023
7 tasks
@jcheng5
Copy link
Member

jcheng5 commented May 10, 2023

LGTM but I'm going to hold off on merging until we know whether we want to roll back the 1.6.10 changes for the immediate release, or roll forward with these fixes.

@jcheng5 jcheng5 changed the base branch from main to dev May 10, 2023 20:05
@jcheng5 jcheng5 self-requested a review May 10, 2023 20:05
src/Makevars Outdated Show resolved Hide resolved
Co-authored-by: Joe Cheng <[email protected]>
@jcheng5 jcheng5 merged commit 979b810 into dev May 10, 2023
@nealrichardson nealrichardson deleted the NDEBUG branch May 10, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants