test(runStaticServer): Improve testing failure when port is in use #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Feb 3, 2024
While here, apply upstream patch to fix tests when all of the unsafe ports are available (e.g. poudriere jail). See also: rstudio/httpuv#396
wch
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393
This PR updates a test for
runStaticServer()that ensures it throws an error if the user requests a port that is already in use (as opposed to finding an unsued port, which is what happens if the user doesn't have a port preference).To test this, we previously found an unsafe and used port, but in certain environments all of the unsafe ports are available (e.g. in freebsd jail). Rather than using the unsafe ports list, this test now starts up a static server and then tries to start a second static server using the same port.
Does this change warrant a NEWS bullet?