Properly handles lack of host or token

rstudio · Sep 30, 2024 · 47de59a · 47de59a
1 parent c5bfbcc
commit 47de59a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/R/board-databricks.R b/R/board-databricks.R
@@ -75,8 +75,14 @@ board_databricks <- function(
 }
 
 board_databricks_test <- function(prefix = NULL) {
-  testthat::skip_if(is.null(db_get_token()), message = "No Databricks credentials found")
-  testthat::skip_if(is.null(db_get_host()), message = "No Databricks host defined")
+  testthat::skip_if(
+    db_get_token(fail = FALSE) == "",
+    message = "No Databricks credentials found"
+  )
+  testthat::skip_if(
+    db_get_host(fail = FALSE) == "",
+    message = "No Databricks host defined"
+  )
   skip_if_missing_envvars(
     tests = "board_databricks()",
     envvars = c("PINS_DATABRICKS_FOLDER_URL")

diff --git a/tests/testthat/_snaps/board-databricks.md b/tests/testthat/_snaps/board-databricks.md
@@ -6,17 +6,3 @@
       Pin board <pins_board_databricks>
       Cache size: 0
 
-# can find board required pkgs
-
-    Code
-      required_pkgs(board)
-    Output
-      [1] "httr2"
-
----
-
-    Code
-      required_pkgs(board)
-    Output
-      [1] "httr2"
-