Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a dribble to define the upload destination path #780

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

gorkang
Copy link
Contributor

@gorkang gorkang commented Sep 3, 2023

This is a potential fix to #777

Instead of passing a full path to drive_upload, with this pr we first create a dribble with the destination folder, and then use it as a path.

In my computer, it works with a single or multiple files, uploading to the main google drive folder or to folder with a long path.

For example, now this works without any issues:

drive_link = "https://drive.google.com/drive/folders/1_jiG0VtENy5QcLRziN7DM_zQD4egwGuN"
googledrive::drive_auth(email = "[email protected]")
gdrive_board = pins::board_gdrive(drive_link)
gdrive_board |> pins::pin_upload(paths = "~/Downloads/999.zip", name = "Id_pin")

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this fix @gorkang! 🙌 I tested it out locally and this works great for me with my own Google Drive.

(Side note: We don't run the Google Drive or MS OneDrive tests in CI because they are so slow and authentication is such a hassle.)

The round trip R 🔄 Python tests are failing right now because of a Python package dependency issue, but we'll get that sorted and then I'll merge this in.

@juliasilge
Copy link
Member

We got the Python problem fixed in rstudio/pins-python#212. 👍

@juliasilge juliasilge merged commit e70b02e into rstudio:main Sep 5, 2023
14 checks passed
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants