Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "write" to warning about using full name when referencing pin #787

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

rkb965
Copy link
Contributor

@rkb965 rkb965 commented Sep 20, 2023

Closes #786

See discussion posit-conf-2023/vetiver#31

@juliasilge
Copy link
Member

This function is used not only when reading or writing pin contents, but also when calling pin_meta() and pin_exists(). Instead of just adding "write", can we change the message to be more like the one here:

i = "Use a fully specified name including user name like {.val {paste0('julia/', name$name)}}"

R/board_connect.R Outdated Show resolved Hide resolved
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @rkb965! 🚀

@juliasilge juliasilge merged commit b853504 into rstudio:main Sep 25, 2023
14 checks passed
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix confusing message about "when reading a pin" for pin_write()
2 participants