Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve object cleanup #145

Merged
merged 13 commits into from
Jan 28, 2023
Merged

Improve object cleanup #145

merged 13 commits into from
Jan 28, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 6, 2023

  • Make message more informative
  • Switch from warning() to cat() so can test it (condition handling is disabled during gc())
  • Release object to avoid additional message on pool close

* Make message more informative
* Switch from `warning()` to `cat()` so can test it (condition handling is disabled during `gc()`)
* Release object to avoid additional message on pool close

Fixes #95
@hadley hadley requested a review from jcheng5 January 6, 2023 14:36
R/pool.R Outdated Show resolved Hide resolved
@hadley
Copy link
Member Author

hadley commented Jan 27, 2023

Now includes thorough pass over all error messages and conversion of all warnings to cat(file = stderr()).

@hadley
Copy link
Member Author

hadley commented Jan 27, 2023

Joe say: dangerous to do anything in the finalizer because it's so unpredictable. So back that out.

@hadley
Copy link
Member Author

hadley commented Jan 27, 2023

Need to convert all tryCatch() to withCallingHandlers()

@hadley hadley merged commit d777a58 into main Jan 28, 2023
@hadley hadley deleted the object-cleanup branch January 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant