tolerate errors when querying available packages #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Jul 25, 2023
| skip_on_cran() | ||
| skip_if_not(grepl("\\bbinary\\b", .Platform$pkgType)) | ||
|
|
||
| dbs <- available_packages( |
There was a problem hiding this comment.
What should the snapshot capture? (since the set of available packages from CRAN will change over time)
There was a problem hiding this comment.
It's also possible that drat could start providing binaries in the future (or at least provide the infrastructure so available.packages() doesn't complain) so I think a snapshot test doesn't quite fit.
There was a problem hiding this comment.
I was thinking you'd want to capture the "renv was unable to query available package" message (and couldn't you just use a url that was guaranteed not to be a repo?)
There was a problem hiding this comment.
That is a very good point! I'll update in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1578.