Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use lock when synchronizing with cache #1598

Merged
merged 2 commits into from
Jul 26, 2023
Merged

use lock when synchronizing with cache #1598

merged 2 commits into from
Jul 26, 2023

Conversation

kevinushey
Copy link
Collaborator

Closes #1571.

@kevinushey kevinushey requested a review from hadley July 25, 2023 23:31
@kevinushey kevinushey mentioned this pull request Jul 25, 2023
Closed
hadley
hadley approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do locks work in renv? Will it block until the lock is available?

@kevinushey
Copy link
Collaborator Author

How do locks work in renv? Will it block until the lock is available?

Yep, that's right.

@kevinushey kevinushey merged commit a7a6ed2 into main Jul 26, 2023
12 checks passed
@hadley hadley deleted the bugfix/cache-locking branch July 26, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running renv::restore() in parallel will fail
2 participants
@kevinushey @hadley