avoid using 'writef' for warning / error style output #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
commented
Jul 27, 2023
| @@ -89,13 +89,10 @@ renv_available_packages_query <- function(type, repos, quiet = FALSE) { | |||
| if (empty(errors)) | |||
| return(dbs) | |||
|
|
|||
| if (!is_testing()) | |||
There was a problem hiding this comment.
I wonder if renv_pretty_print needs a new name, and if it should just write output by default. We almost always use it for "warning"-style output.
hadley
reviewed
Jul 27, 2023
kevinushey
commented
Jul 27, 2023
aronatkins
reviewed
Jul 27, 2023
hadley
approved these changes
Jul 27, 2023
| renv_scope_options(renv.verbose = TRUE) | ||
| writef(lines, renv_difftime_format(elapsed)) | ||
| # force output in this scope | ||
| renv_scope_caution(TRUE) |
There was a problem hiding this comment.
It is, but it's forced TRUE here because we want to display this message even if caution was disabled (e.g. as we do in the "synchronized" check)
| return(FALSE) | ||
| } | ||
|
|
||
| # otherwise, use status to detect if we're synchronized | ||
| info <- local({ | ||
| renv_scope_options(renv.verbose = FALSE) | ||
| renv_scope_caution(FALSE) |
There was a problem hiding this comment.
Are you sure this should be set fo FALSE here?
There was a problem hiding this comment.
Yes, because we want to avoid the regular "noisy" output from status in this scope -- instead, we want to ask users to run renv::status() themselves to see the full log.
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1607.
Addresses #1608.
Still needs tests.
Still needs NEWS.