Support new Pandoc 3.4 behavior with GFM math #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd $ for math in GFM documents.
[skip ci]
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Oct 17, 2024
Merge remote-tracking branch 'rstudio/main' into jg-devel # By Yihui Xie (4) and others # Via GitHub * rstudio/main: parameters with `choices` and `multiple = TRUE` should use a `select` input (rstudio#2576) Add support for `child=c("child.Rmd")` in find_external_resources() (rstudio#2575) Support new Pandoc 3.4 behavior with GFM math (rstudio#2573) consistent dev install instructions (rstudio#2571) Update actions/checkout to v4 (rstudio#2570) start the next version CRAN release v2.28 update tests for lua filters accordingly fix rstudio#2567: add classes `odd`, `even`, and `header` back to table rows for Pandoc >= 3.2.1 # Conflicts: # DESCRIPTION # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Oct 17, 2024
* jg-devel: parameters with `choices` and `multiple = TRUE` should use a `select` input (rstudio#2576) Add support for `child=c("child.Rmd")` in find_external_resources() (rstudio#2575) Support new Pandoc 3.4 behavior with GFM math (rstudio#2573) consistent dev install instructions (rstudio#2571) Update actions/checkout to v4 (rstudio#2570) start the next version CRAN release v2.28 update tests for lua filters accordingly fix rstudio#2567: add classes `odd`, `even`, and `header` back to table rows for Pandoc >= 3.2.1
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Oct 17, 2024
* rstudio-main: parameters with `choices` and `multiple = TRUE` should use a `select` input (rstudio#2576) Add support for `child=c("child.Rmd")` in find_external_resources() (rstudio#2575) Support new Pandoc 3.4 behavior with GFM math (rstudio#2573) consistent dev install instructions (rstudio#2571) Update actions/checkout to v4 (rstudio#2570) start the next version CRAN release v2.28 update tests for lua filters accordingly fix rstudio#2567: add classes `odd`, `even`, and `header` back to table rows for Pandoc >= 3.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2572
As explained in this issue, Pandoc does by default uses the alternative GFM syntax for math.
In
github_document(), we choose to keep writing the dollars syntax$$and$to avoid any future breakage.In the future, we may add an option to activate the writing of
```mathand$`if necessary. It seems they were added by Github to handle specific charactershttps://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/writing-mathematical-expressions