-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow refactor #588
Workflow refactor #588
Conversation
9693221
to
7ebf3ed
Compare
fe7a0d9
to
346801f
Compare
07d0fb8
to
aa512ff
Compare
aa512ff
to
856a16f
Compare
- Update all Quarto to 1.3.340 - Pass Quarto down as build arg
Add base-pro build
Update all versions after changes
This reverts commit 4dace23.
Fix naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. Having common build steps across all the images should be very helpful.
I had just a few comments, but none of them need to be addressed before merging.
Co-authored-by: Benjamin R. J. Schwedler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for refactoring all of this!
Closes #586
Workflow Changes
.github/actions/build-test-scan-push
, which builds a specified image, tests it using Goss, scans it with Snyk, and pushes it. The last three steps are optional and can be enabled/disabled based on the needs of the user or workflow.build-release.yaml
- Builds the base image, base image w/ pro drivers, and then each product image utilizing the above action. This pipeline will trigger on merges and on a scheduled basis to keep images up to date with security patches, something we lacked on the previous revision. Replacesbuild-latest.yaml
.build-prerelease.yaml
- Builds preview/daily images for each product as defined in the workflow matrix. Replacesbuild-preview.yaml
.build-manual.yaml
- Allows repository administrators to perform one off manual builds of daily, preview, and release builds. This workflow is still in development and will likely need future work. The hope is that having this workflow will give us a quicker way of updating previously built images. Replacesbuild-preview-webhook.yaml
..github/actions/build-test-scan-push
, but have otherwise remained unchanged.ci.Justfile
build shortcuts that were being used by previous workflows and replaces them with shortcuts for getting arguments and tags for each image.just
have been removed in favor of official Github Action calls. The primary driver for this change was a bug with usingbuildx
in Github Actions that caused properly exported images to disappear in later steps, causing things like tests to fail.Other Changes
Justfile
for updating Quarto versions across the project. This should stop Quarto from getting out of date across projects.3.9.17
and3.8.17
(alternate). CentOS 7 builds are pinned back to3.9.14
and3.8.15
, the distribution's latest successful builds.3.6.x
have been removed and replaced with4.2.3
and4.1.3
(alternate).JUPYTER_PYTHON_VERSION
toPYTHON_VERSION_JUPYTER
for consistency.trimSuffix "-1"
for pro driver version Goss tests on RHEL-based systems.rstudio-connect.gcfg
to replace Python versions with the primary version the image is built with at build time.