You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With fastapi==0.109.0/ starlette==0.35.0, there have been breaking changes to how root_path is used within APIs. While vetiver doesn't use this directly, it is the way test paths are set inside TestClient, so many of our tests are failing.
... if it [root_path] is set, it will be passed to the ASGI apps, that will internally extract/remove it from the paths. But clients communicating with those ASGI apps, if they are indeed mounted at the defined root_path, would have to communicate with it using the root_path prefix. So this PR updates the client to actually require/use that, clients created with root_path would need to be used the same way that clients communicating with those ASGI apps mounted at some prefix path.
The text was updated successfully, but these errors were encountered:
With
fastapi==0.109.0
/starlette==0.35.0
, there have been breaking changes to howroot_path
is used within APIs. While vetiver doesn't use this directly, it is the way test paths are set insideTestClient
, so many of our tests are failing.from encode/starlette#2400
The text was updated successfully, but these errors were encountered: