Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests #209

Merged
merged 2 commits into from
Mar 25, 2024
Merged

refactor tests #209

merged 2 commits into from
Mar 25, 2024

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Mar 25, 2024

closes #207

  • move from checking if TestClient to passing in a test client as a kwarg to vetiver.predict()
  • use pkg_resoruces to import data (current way of importing from vetiver.data module is no longer compatible with pytest)
  • move creation of vetiver apis with and without prototypes to conftest.py
  • some other general ergonomics

@isabelizimm isabelizimm reopened this Mar 25, 2024
@isabelizimm isabelizimm marked this pull request as ready for review March 25, 2024 22:18
@isabelizimm isabelizimm merged commit 6d0e199 into main Mar 25, 2024
11 checks passed
@isabelizimm isabelizimm deleted the refactor-tests branch March 25, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maint: remove root_path usage in TestClient
1 participant