Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] update docs to look less like vetiver.rstudio.com #178

Merged
merged 7 commits into from
May 31, 2023
Merged

Conversation

isabelizimm
Copy link
Contributor

After gathering community feedback, we may have made too unified of a look between the Python package docs and vetiver.rstudio.com. This PR is to update the look as well as add in links to the R package docs

@isabelizimm
Copy link
Contributor Author

isabelizimm commented May 18, 2023

@machow any quick guesses as to why quartodoc isn't able to render VetiverModel anymore? maybe something to pair on to clean everything up/think about debugging strategies, since I know you've been making lots of big moves in quartodoc land!

@juliasilge
Copy link
Member

You can see the (minor) changes I made to the R pkgdown site navbar here now: https://rstudio.github.io/vetiver-r/dev/

@isabelizimm
Copy link
Contributor Author

HMMMM what is happening in this Docs Check 😩

@has2k1
Copy link
Collaborator

has2k1 commented May 19, 2023

HMMMM what is happening in this Docs Check 😩

I think there is a missing secret token.

@isabelizimm
Copy link
Contributor Author

HMMMM what is happening in this Docs Check 😩

I think there is a missing secret token.

Yeah, the deployment_id is missing because the docs are breaking upon build (a successful docs build will populate this ID). I had installed off a branch of quartodoc locally and am using some new/not backwards compatible features, so I'll plan to rerun and merge this PR on quartodoc's next release!

@machow
Copy link
Contributor

machow commented May 25, 2023

I don't think we were able to locally reproduce this specific error last week when pairing (but were able to generate the site locally), so am a bit stumped on what might be going on. Maybe we can take a pass when pairing on Tues, and try updating all requirements?

@isabelizimm
Copy link
Contributor Author

I don't think we were able to locally reproduce this specific error last week when pairing (but were able to generate the site locally), so am a bit stumped on what might be going on. Maybe we can take a pass when pairing on Tues, and try updating all requirements?

Yeah, this sounds good to me!

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

docs/_quarto.yml Outdated Show resolved Hide resolved
docs/_quarto.yml Outdated Show resolved Hide resolved
docs/_quarto.yml Outdated Show resolved Hide resolved
docs/_quarto.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants