Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] bump minimum rsconnect to 1.11.0 #200

Merged
merged 4 commits into from
Oct 27, 2023
Merged

[MAINT] bump minimum rsconnect to 1.11.0 #200

merged 4 commits into from
Oct 27, 2023

Conversation

isabelizimm
Copy link
Contributor

If people try to use an older version of rsconnect-python, we no longer supply the conda_mode value in deploy_rsconnect, so it will fail on deployment.

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Oct 27, 2023 •
edited
Loading

This failure is a little peculiar, I don't think the requirements.txt generated on deploy is following the rsconnect>=1.21.0 restriction. EDIT: we were a bit overzealous stripping out conda_mode. Although it is ultimately ignored, it still must be passed in.

@isabelizimm isabelizimm marked this pull request as ready for review October 27, 2023 18:20
@isabelizimm isabelizimm changed the title [MAINT] bump minimum rsconnect to 1.21.0 [MAINT] bump minimum rsconnect to 1.11.0 Oct 27, 2023
@isabelizimm isabelizimm merged commit 6a88d23 into main Oct 27, 2023
11 checks passed
@isabelizimm isabelizimm deleted the bump-rsconnect branch October 27, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isabelizimm