Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix for load_pkgs function on Windows OS #98

Merged
merged 2 commits into from
Aug 19, 2022
Merged

bug fix for load_pkgs function on Windows OS #98

merged 2 commits into from
Aug 19, 2022

Conversation

M4thM4gician
Copy link
Contributor

Change to load_pkgs function:

  • Change temp file creation to not delete when file closed (delete=False)
  • Close temp file immediately after creating
  • Remove temp file after compiled into requirements.txt file

@M4thM4gician M4thM4gician reopened this Aug 19, 2022
isabelizimm
isabelizimm reviewed Aug 19, 2022
View reviewed changes
vetiver/attach_pkgs.py Outdated Show resolved Hide resolved
@isabelizimm isabelizimm merged commit dd4a5ed into rstudio:main Aug 19, 2022
@isabelizimm
Copy link
Contributor

Thank you so much for this contribution!
closes #97

@isabelizimm isabelizimm linked an issue Aug 19, 2022 that may be closed by this pull request
load_pkgs doesn't work on Windows #97
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelizimm isabelizimm isabelizimm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load_pkgs doesn't work on Windows
3 participants
@M4thM4gician @isabelizimm @TomRuhland