Fix parameters with schema reference #564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reading https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#parameterObject it says that
schema
can be a "Schema Object" or a "Reference Object".I think the code on
rswag/specs/request_factory.rb
is not prepared for the "Reference Object" option. Whenschema
has a$ref
and not atype
it raises an exception:Solution
Don't raise an exception, and instead add a fallback as we had before version
2.6.0
.This concerns this parts of the Open API Specification:
The changes I made are compatible with:
Related Issues
#563
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.