Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update template to ask for dependency versions #575

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Nov 8, 2022

Suggestion to ask contributors for more of their environment.

Also, adding a few minor changes in comments/texts. No change that would influence behavior.

Problem

Could be easier to ask for package versions right away.

Solution

Add field to note package versions into issue template.

(using the list of dependencies requested at #559 (comment))

This concerns this parts of the Open API Specification:

The changes I made are compatible with:

  • OAS2
  • OAS3
  • OAS3.1

Related Issues

Checklist

  • Added tests
  • Changelog updated
  • Added documentation to README.md

Steps to Test or Reproduce

@romanblanco romanblanco marked this pull request as ready for review November 8, 2022 10:52
Copy link
Collaborator

@jtannas jtannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 typos :)
otherwise all good

.github/pull_request_template.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@romanblanco
Copy link
Member Author

@jtannas Thanks!

@jtannas
Copy link
Collaborator

jtannas commented Nov 27, 2022

@romanblanco sorry for not getting back to this sooner. Just ping me when the changelog merge conflict (from the 2.8.0 release) is resolved and I'll merge straight away.

@romanblanco
Copy link
Member Author

@jtannas No worries, updated 😉

@jtannas jtannas merged commit bfe4103 into rswag:master Jan 9, 2023
@romanblanco romanblanco deleted the ask-for-dep-version branch January 9, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants