Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty custom messages #174

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

modalkonform
Copy link
Contributor

The LoveToKnow/slackify-markdown-action fails if text input is empty.
So it's only called if the respective env var is set.

In the actual call to action-slack-notify i overwrite empty values of those custom env vars with the default message SLACK_MESSAGE because otherwise the messages would be empty since the implementation of envOrin main.go only checks if the env var is set and not if the value is an empty string.

It's not beautiful but it's a limitation of the fact that GITHUB_ENV cannot be overwritten in composite workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant