Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #291

Closed
dhsathiya opened this issue Jan 17, 2023 · 8 comments
Closed

PHP 8.1 compatibility #291

dhsathiya opened this issue Jan 17, 2023 · 8 comments
Assignees

Comments

@dhsathiya
Copy link
Member

Getting PHP Deprecated notics when switching my php version from 7.4 to 8.1
Please fix to make your plugin perfectly compatible with php 8.1:

[19-Aug-2022 19:02:23 UTC] PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /wp-content/plugins/nginx-helper/admin/class-nginx-helper-admin.php on line 676
[19-Aug-2022 19:02:23 UTC] PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /wp-content/plugins/nginx-helper/admin/class-nginx-helper-admin.php on line 681

Ref - https://wordpress.org/support/topic/php-8-1-compatibility-7/

@danish17
Copy link

@Souptik2001, did you make any fixes?

@Souptik2001
Copy link
Member

@danish17 Yes the fixes are done. We are in the testing phase now.

@aviral-mittal
Copy link

@Souptik2001 Can you please point us to the PR in which this fix has been made.

@Souptik2001
Copy link
Member

@aviral-mittal I have not yet raised the PR as all the tests are not yet complete.
Just FYI here is the branch with the changes - https://github.com/Souptik2001/nginx-helper/tree/fix/GH-291

@gagan0123
Copy link
Member

@Souptik2001 Any estimates on when the tests will be completed?

@Souptik2001
Copy link
Member

@gagan0123 It should be done by tomorrow. Starting with multi-site testing now.

@pgnd
Copy link

pgnd commented Apr 9, 2023

@Souptik2001 @gagan0123

what are current plans for merging this fix, and pushing a release ?

SID177 added a commit that referenced this issue May 15, 2023
Fix PHP 8.1 compatibility issues and phpcs
@dhsathiya
Copy link
Member Author

We have provided PHP8.1 compatibility with the latest release.
Closing the issue in favour of the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants