Refactor remove_dir

[stsewd]

Closes #4297

[codecov]

Codecov Report

Merging #4994 into master will decrease coverage by <.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
- Coverage   76.76%   76.75%   -0.01%     
==========================================
  Files         158      158              
  Lines        9953     9951       -2     
  Branches     1245     1245              
==========================================
- Hits         7640     7638       -2     
  Misses       1980     1980              
  Partials      333      333

Impacted Files	Coverage Δ
readthedocs/builds/models.py	78.83% <0%> (ø)	⬆️
readthedocs/projects/views/private.py	80.05% <100%> (ø)	⬆️
readthedocs/projects/admin.py	91.5% <100%> (ø)	⬆️
readthedocs/projects/tasks.py	71.08% <50%> (-0.12%)	⬇️
readthedocs/core/views/__init__.py	71.01% <50%> (ø)	⬆️

[codecov]

Codecov Report

Merging #4994 into master will decrease coverage by 0.1%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
- Coverage   76.85%   76.75%   -0.11%     
==========================================
  Files         158      158              
  Lines        9991     9951      -40     
  Branches     1254     1245       -9     
==========================================
- Hits         7679     7638      -41     
- Misses       1978     1980       +2     
+ Partials      334      333       -1

Impacted Files	Coverage Δ
readthedocs/builds/models.py	78.83% <0%> (ø)	⬆️
readthedocs/projects/views/private.py	80.05% <100%> (+0.41%)	⬆️
readthedocs/projects/admin.py	91.5% <100%> (ø)	⬆️
readthedocs/projects/tasks.py	71.08% <50%> (+0.6%)	⬆️
readthedocs/core/views/__init__.py	71.01% <50%> (+0.42%)	⬆️
readthedocs/vcs_support/backends/svn.py	29.5% <0%> (-9.89%)	⬇️
readthedocs/core/utils/__init__.py	74.73% <0%> (-5.68%)	⬇️
readthedocs/vcs_support/backends/git.py	81.98% <0%> (-1.93%)	⬇️
readthedocs/projects/querysets.py	80.58% <0%> (-0.9%)	⬇️
readthedocs/projects/forms.py	79.66% <0%> (-0.34%)	⬇️
... and 9 more

[stsewd]

Believe #4895 will help with the coverage here

[ericholscher]

Fixed my comment in a commit, think this is good to go.