Remove unnecessary Junit dependency #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution @robertszuba - as it happens Spongy Castle is a repackage of Bouncy Castle, targeted at Android, with no substantial differences to the code (just renaming of packages, etc). So if you've got an issue that relates to the underlying Bouncy Castle codebase, it's better to raise the issue with the GitHub repository for Bouncy Castle at https://github.com/bcgit/bc-java . It turns out that this issue was fixed in Bouncy Castle with bcgit@9f7320cd0d4e, which made it into |
|
You can build your own BC/SC jars from the current version (1.62), see my comment on issue #34. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
provmodule declares the Junit library as a runtime dependency. The library is only needed for the test step during compile time - thetestCompiledependency is already added in the top level build.gradle of the project. The runtime dependency definition can generate warnings in the end-app builds.