Skip to content

Commit

Permalink
Make WorkspaceFolder.name required according to the spec (eclipse-l…
Browse files Browse the repository at this point in the history
  • Loading branch information
jnt0r authored Sep 13, 2023
1 parent 3a56de0 commit 3c98376
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Fixed issues: <https://github.com/eclipse-lsp4j/lsp4j/milestone/29?closed=1>

Breaking API changes:

* The name field in WorkspaceFolder is no longer optional according to the specification.
* See [#741](https://github.com/eclipse-lsp4j/lsp4j/issues/741) for detailed discussion.

Nightly japicmp report: <https://download.eclipse.org/lsp4j/builds/main/japicmp-report/>

### [v0.21.1 (August 2023)](https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.21.1)
Expand Down
13 changes: 5 additions & 8 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Original file line number Diff line number Diff line change
Expand Up @@ -7995,20 +7995,17 @@ class WorkspaceFolder {
@NonNull String uri

/**
* The name of the workspace folder. Defaults to the uri's basename.
* The name of the workspace folder. Used to refer to this
* workspace folder in the user interface.
*/
String name
@NonNull String name

new() {
}

new(@NonNull String uri) {
new(@NonNull String uri, @NonNull String name) {
this.uri = Preconditions.checkNotNull(uri, 'uri')
}

new(@NonNull String uri, String name) {
this(uri)
this.name = name
this.name = Preconditions.checkNotNull(name, 'name')
}
}

Expand Down

0 comments on commit 3c98376

Please sign in to comment.