Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output error message on espree error #143

Merged
merged 2 commits into from
May 25, 2016
Merged

Output error message on espree error #143

merged 2 commits into from
May 25, 2016

Conversation

gabegorelick
Copy link
Collaborator

@gabegorelick gabegorelick commented May 21, 2016 •
edited
Loading

Don't silently continue on when we encounter an espree error. Instead, output the location of the parse error, then continue on.

See #140.

@gabegorelick gabegorelick mentioned this pull request May 21, 2016
Closed
@rubenv rubenv merged commit a65a64b into rubenv:master May 25, 2016
@rubenv
Copy link
Owner

rubenv commented May 25, 2016

Cool, thanks @gabegorelick!

@rubenv
Copy link
Owner

rubenv commented May 25, 2016

Released as v2.2.1.

@NicoPennec
Copy link

This PR create an issue on watch task : #144

@gabegorelick gabegorelick deleted the dont-swallow-parse-errors branch June 20, 2016 22:34
@piotr-dobrogost
Copy link

piotr-dobrogost commented Aug 1, 2018 •
edited
Loading

I was not getting location of parse error and inspecting err object revealed it has pos and loc attributes but no lineNumber nor column. Has err object changed since this pull was created? I raised this problem in issue #186.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabegorelick @rubenv @NicoPennec @piotr-dobrogost