Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for claiming in-game usernames #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vmunich
Copy link

@vmunich vmunich commented Jul 27, 2016

Usage:

After session = poko_session.authenticate():

session.claimCodename('desired_username')
codename: "desired_username"
user_message: "Codename is claimed."
is_assignable: true
status: SUCCESS

@vmunich vmunich changed the title Adds support for claiming in-game usernames Add support for claiming in-game usernames Jul 27, 2016
@rubenvereecken
Copy link
Owner

What do you say we switch to calling it Username instead? I'll probably send in a whooole bunch of renames to the protobuf repository anyway. A lot of the message names honestly suck.

Otherwise this is looking great!

@vmunich
Copy link
Author

vmunich commented Jul 28, 2016

That's fine :) I called it like the other methods were called. One thing I realized is, you can change your username whenever you want with this call, even set your username to a username that's already being used. The status returns ALREADY_IN_USE but it changes the username anyway :D

@vmunich
Copy link
Author

vmunich commented Jul 31, 2016

Removed the conflicting code.

Renamed changeCodename() to changeUsername() :)
@dnsBlah
Copy link
Contributor

dnsBlah commented Aug 8, 2016

@vmunich Unfortunally it's solved now, if there already is a codename set, you can't change it anymore.
You can only change 1 time now :(

@vmunich
Copy link
Author

vmunich commented Aug 10, 2016

@dnsBlah yea that's sadly true :(

@dmadisetti
Copy link
Collaborator

So this is no longer valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants