Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI on JRuby #132

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Enable CI on JRuby #132

merged 1 commit into from
Nov 2, 2024

Conversation

marcandre
Copy link
Contributor

No description provided.

@enebo
Copy link

enebo commented Mar 24, 2021

@marcandre I noticed in GHA that JRuby is not run with --dev. JRUBY_OPTS=--dev on my machine drops spec runs from 25s to 15s. Hopefully takes a little sting out of adding us to CI.

@enebo
Copy link

enebo commented Mar 24, 2021

If set as an ENV this will also speed up the bundle install as well.

@marcandre
Copy link
Contributor Author

Cool, thanks @enebo! #175

@enebo
Copy link

enebo commented Mar 24, 2021

@marcandre I also submitted ruby/setup-ruby#164 which should remove 10s of installing bundler on jruby-head (I noticed truffle ruby already does this and MRI 2.7+).

@headius
Copy link

headius commented Mar 26, 2021

ruby/setup-ruby#164 has merged, perhaps we will see it in effect soon on rubocop-ast builds? 😀

@marcandre
Copy link
Contributor Author

Not yet, it is installing 9.2.16 right now.

@bbatsov
Copy link
Contributor

bbatsov commented Nov 2, 2024

@marcandre I guess we should check if it's working now. 😅

@headius
Copy link

headius commented Nov 2, 2024

FWIW, current JRuby runs both spec and prism_spec green.

@marcandre marcandre merged commit eb91347 into rubocop:master Nov 2, 2024
21 checks passed
@marcandre marcandre deleted the jruby branch November 2, 2024 17:35
@marcandre
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants