Merge pull request #151 from koic/fix_false_positive_for_assert_empty…

…_and_refute_empty

[Fix #150] Fix a false positive for `Minitest/AssertEmpty` and `RefuteEmpty`

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Bug fixes
 
 * [#142](https://github.com/rubocop/rubocop-minitest/issues/142): Fix `Minitest/GlobalExpectations` autocorrect when receiver is lambda. ([@gi][])
+* [#150](https://github.com/rubocop/rubocop-minitest/issues/150): Fix a false positive for `Minitest/AssertEmpty` and `RefuteEmpty` cops when using `empty` method with any arguments. ([@koic][])
 
 ## 0.15.2 (2021-10-11)
 

lib/rubocop/cop/minitest/assert_empty.rb

@@ -19,6 +19,17 @@ class AssertEmpty < Base
         extend MinitestCopRule
 
         define_rule :assert, target_method: :empty?
+
+        def on_send(node)
+          return unless node.method?(:assert)
+          return unless (arguments = peel_redundant_parentheses_from(node.arguments))
+          return unless arguments.first.respond_to?(:method?) && arguments.first.method?(:empty?)
+          return unless arguments.first.arguments.empty?
+
+          add_offense(node, message: offense_message(arguments)) do |corrector|
+            autocorrect(corrector, node, arguments)
+          end
+        end
       end
     end
   end

lib/rubocop/cop/minitest/refute_empty.rb

@@ -19,6 +19,17 @@ class RefuteEmpty < Base
         extend MinitestCopRule
 
         define_rule :refute, target_method: :empty?
+
+        def on_send(node)
+          return unless node.method?(:refute)
+          return unless (arguments = peel_redundant_parentheses_from(node.arguments))
+          return unless arguments.first.respond_to?(:method?) && arguments.first.method?(:empty?)
+          return unless arguments.first.arguments.empty?
+
+          add_offense(node, message: offense_message(arguments)) do |corrector|
+            autocorrect(corrector, node, arguments)
+          end
+        end
       end
     end
   end

test/rubocop/cop/minitest/assert_empty_test.rb

@@ -94,4 +94,14 @@ def test_do_something
       end
     RUBY
   end
+
+  def test_does_not_register_offense_when_using_assert_empty_method_with_any_arguments
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        def test_do_something
+          assert(File.empty?(path))
+        end
+      end
+    RUBY
+  end
 end

test/rubocop/cop/minitest/refute_empty_test.rb

@@ -94,4 +94,14 @@ def test_do_something
       end
     RUBY
   end
+
+  def test_does_not_register_offense_when_using_refute_empty_method_with_any_arguments
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        def test_do_something
+          refute(File.empty?(path))
+        end
+      end
+    RUBY
+  end
 end