Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require RuboCop 0.87 or higher #104

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

koic
Copy link
Member

@koic koic commented Jul 11, 2020

RuboCop Minitest requires RuboCop 0.87 or higher due to use the new Autocorrection API.
rubocop/rubocop#7868


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

RuboCop Minitest requires RuboCop 0.87 or higher due to
use the new Autocorrection API.
rubocop/rubocop#7868
@koic koic force-pushed the require_rubocop_0_87_or_higher branch from ee73777 to d1b4585 Compare July 11, 2020 08:03
@koic koic merged commit 1fbc260 into rubocop:master Jul 11, 2020
@koic koic deleted the require_rubocop_0_87_or_higher branch July 11, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant