-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NoAssertions
cop
#124
Add NoAssertions
cop
#124
Conversation
5ff630c
to
3371f33
Compare
I posted a question in the issue that I think still needs to be addressed:
|
I don't have any good ideas for this, sorry for not addressing it directly. The I guess this is where |
5aad9f0
to
2099d41
Compare
Thanks @koic I made all those changes. |
2099d41
to
23623ea
Compare
23623ea
to
af847a1
Compare
af847a1
to
d0d6921
Compare
Great! Thanks @ghiculescu! |
Should have tested rubocop#124 more thoroughly
Should have tested rubocop#124 more thoroughly
Should have tested rubocop#124 more thoroughly
Here's another approach to catching tests without assertions: https://railsatscale.com/2024-01-25-catching-assertionless-tests |
Fixes #123