Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Minitest/AssertEmptyLiteral as safe auto-correction #145

Conversation

koic
Copy link
Member

@koic koic commented Oct 2, 2021

This PR marks Minitest/AssertEmptyLiteral as safe auto-correction.
Introduced as unsafe auto-correction in #85, but now safe auto-correction with changes in #118.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR marks `Minitest/AssertEmptyLiteral` as safe auto-correction.
Introduced as unsafe auto-correction in rubocop#85, but now safe auto-correction
with changes in rubocop#118.
@koic koic merged commit 6ddf6f7 into rubocop:master Oct 3, 2021
@koic koic deleted the mark_minitest_assert_empty_literal_as_safe_autocorrection branch October 3, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant