-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new cop Minitest/NoTestCases
#218
Conversation
Lgtm 👍 |
I tried this cop with the rails/rails repo and it seems to find a lot of false positives. Could you take a look? |
@koic Rails test suite defines lots of temp test classes without any tests. Some examples:
I am not sure how to fix them safely. Any ideas? |
Isn't this rule too strict? I'm concerned that there are more opportunities for false positives than for detected true offenses. TBH, I don't have a sense of user-friendliness. |
First example: it just incorrectly detects non test class. That should be fixed. Personally, I see a value of this cop. Maybe not inside the |
Yeah, it looks a reasonable idea. @tejasbubane Can you disable this cop by default? |
@koic Disabled by default. |
Closes #216
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.