Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Minitest/GlobalExpectations aware of pattern matchers #244

Conversation

koic
Copy link
Member

@koic koic commented Mar 11, 2023

Follow up minitest/minitest@0c44f4e

This PR makes Minitest/GlobalExpectations aware of must_pattern_match and wont_pattern_match matchers.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up minitest/minitest@0c44f4e

This PR makes `Minitest/GlobalExpectations` aware of
`must_pattern_match` and `wont_pattern_match` matchers.
@koic koic force-pushed the make_minitest_global_expectations_aware_of_pattern_matchers branch from 5d6590f to 5c18a78 Compare March 11, 2023 06:57
@koic koic merged commit b6c7635 into rubocop:master Mar 19, 2023
@koic koic deleted the make_minitest_global_expectations_aware_of_pattern_matchers branch March 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant