Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Minitest/GlobalExpectations cop #69

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

koic
Copy link
Member

@koic koic commented Mar 16, 2020

Fix a false negative for Minitest/GlobalExpectations cop when using a variable or a hash index for receiver.

The following is a false nagative example.

signed_url_params["Signature"].must_equal [Base64.strict_encode64("native-signature").delete("\n")]

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fix a false negative for `Minitest/GlobalExpectations` cop when
using a variable or a hash index for receiver.

The following is a false nagative example.

```ruby
signed_url_params["Signature"].must_equal [Base64.strict_encode64("native-signature").delete("\n")]
```
@koic koic merged commit 468e2fe into rubocop:master Mar 16, 2020
@koic koic deleted the fix_false_negative_for_global_expections branch March 16, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant