Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DoubleStartEndWith example #419

Closed
wants to merge 1 commit into from
Closed

Conversation

catlee
Copy link

@catlee catlee commented Dec 6, 2023

The example code for the DoubleStartEndWith is missing the # bad header for the first section here: https://docs.rubocop.org/rubocop-performance/cops_performance.html#includeactivesupportaliases-false-default

This PR adds the appropriate comments for this example.

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Dec 7, 2023

This seems to be an expected behavior of IncludeActiveSupportAliases: false. Accepting the changes in this PR would make IncludeActiveSupportAliases: false and IncludeActiveSupportAliases: true behave the same.

@koic koic closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants