[Fix #1234] Fix an incorrect autocorrect for Rails/FindBy
#1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Feb 1, 2024
| @@ -59,8 +59,7 @@ def autocorrect(corrector, node) | |||
| return if node.method?(:first) | |||
|
|
|||
| where_loc = node.receiver.loc.selector | |||
| first_loc = range_between(node.loc.dot.begin_pos, node.loc.selector.end_pos) | |||
|
|
|||
| first_loc = range_between(node.receiver.source_range.end_pos, node.loc.selector.end_pos) | |||
There was a problem hiding this comment.
Can you keep the intentional blank line?
Suggested change
| first_loc = range_between(node.receiver.source_range.end_pos, node.loc.selector.end_pos) | |
| first_loc = range_between(node.receiver.source_range.end_pos, node.loc.selector.end_pos) | |
Fixes rubocop#1234. This PR fixes an incorrect autocorrect for `Rails/FindBy` when using multi-line leading dot method calls.
ymap
force-pushed
the
fix_an_incorrect_autocorrect_for_rails_find_by
branch
from
99e19da
to
6b9568c
Compare
|
Looks good to me. Thanks for the fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234.
This PR fixes an incorrect autocorrect for
Rails/FindBywhen using multi-line leading dot method calls.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.