Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Rails/ApplicationRecord to ignore migrations #1349

Merged

Conversation

fatkodima
Copy link
Contributor

Closes #1342.

@koic
Copy link
Member

koic commented Sep 3, 2024

Please document the reason for excluding files under the db/migrate directory in the Rails/ApplicationRecord cop's documentation, as mentioned in #1342.

@fatkodima fatkodima force-pushed the application_record_ignore-migrations branch from 671c8bd to 1dbdede Compare September 3, 2024 16:34
@fatkodima
Copy link
Contributor Author

Added a comment.

@koic
Copy link
Member

koic commented Sep 3, 2024

Adding a comment is a good approach, but can you document it? It would likely be the most helpful for users' understanding:
https://docs.rubocop.org/rubocop-rails/2.26/cops_rails.html#railsapplicationrecord

@fatkodima fatkodima force-pushed the application_record_ignore-migrations branch from 1dbdede to ff07593 Compare September 3, 2024 17:14
@fatkodima
Copy link
Contributor Author

Misinterpreted the previous comment. Add a comment line to the cop file.

@koic koic merged commit 93f9a89 into rubocop:master Sep 4, 2024
14 checks passed
@koic
Copy link
Member

koic commented Sep 4, 2024

Thanks!

@fatkodima fatkodima deleted the application_record_ignore-migrations branch September 7, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/ApplicationModel should ignore db/migrate/**
2 participants