Support filter in Rails/CompactBlank
#1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masato-bkn
force-pushed
the
support-select-alias-methods-for-rails-compact-blank
branch
from
8622e08
to
12894ef
Compare
koic
reviewed
Sep 9, 2024
Comment on lines
125
to
129
| if %i[reject select filter].include?(node.method_name) | ||
| 'compact_blank' | ||
| else | ||
| 'compact_blank!' | ||
| end |
There was a problem hiding this comment.
Can you make this a constant?
Suggested change
| if %i[reject select filter].include?(node.method_name) | |
| 'compact_blank' | |
| else | |
| 'compact_blank!' | |
| end | |
| DESTRUCTIVE_METHODS.include?(node.method_name) ? 'compact_blank!' : 'compact_blank' |
There was a problem hiding this comment.
Thank you for your feedback. I've fixed it!
koic
reviewed
Sep 9, 2024
| @@ -44,7 +46,7 @@ class CompactBlank < Base | |||
| extend TargetRailsVersion | |||
|
|
|||
| MSG = 'Use `%<preferred_method>s` instead.' | |||
| RESTRICT_ON_SEND = %i[reject delete_if select keep_if].freeze | |||
| RESTRICT_ON_SEND = %i[reject delete_if select filter keep_if].freeze | |||
There was a problem hiding this comment.
Suggested change
| RESTRICT_ON_SEND = %i[reject delete_if select filter keep_if].freeze | |
| RESTRICT_ON_SEND = %i[reject delete_if select filter keep_if].freeze | |
| DESTRUCTIVE_METHODS = %i[delete_if keep_if].freeze |
masato-bkn
force-pushed
the
support-select-alias-methods-for-rails-compact-blank
branch
from
12894ef
to
9980211
Compare
|
Thanks! |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
Rails/CompactBlankto supportfilter.Since
filteris an alias forselectin both Array and Hash, I think it can be handled in the same way asselect.Before submitting the PR make sure the following are checked:
[ ] Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.