Fix Rails/TimeZone should not report offense on String#to_time with timezone specifier
#1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th timezone specifier
As `Time.parse("2012-03-02T16:05:37Z")` is allowed, `"2012-03-02T16:05:37Z".to_time` should also be allowed.
koic
reviewed
Sep 19, 2024
| @@ -27,7 +27,8 @@ module Rails | |||
| # Time.current | |||
| # Time.zone.now | |||
| # Time.zone.parse('2015-03-02T19:05:37') | |||
| # Time.zone.parse('2015-03-02T19:05:37Z') # Respect ISO 8601 format with timezone specifier. | |||
There was a problem hiding this comment.
Was this an intentional removal? If so, what was the intention behind it?
There was a problem hiding this comment.
Sorry I wanted to explain the change in the PR body and forgot to do it
This example was added in PR #441 which specifically allows Time.parse when a timezone specifier is present so Time.parse(...) seems like the good syntax in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Time.parse("2012-03-02T16:05:37Z")is allowed,"2012-03-02T16:05:37Z".to_timeshould also be allowed.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.